qgis: add server support by imincik · Pull Request #267301 · NixOS/nixpkgs

imincik · 2023-11-13T21:10:26Z

Description of changes

Add QGIS server support for QGIS and QGIS-LTR.

This PR is co-authored by @bgamari in #259303 .

Things done

imincik · 2023-11-15T04:53:14Z

@ofborg build qgis qgis-ltr

nixos-discourse · 2023-12-18T20:07:21Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team-11-17-dec-2023/37035/1

nixos-discourse · 2024-01-09T08:49:16Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/2

nialov · 2024-01-14T07:48:29Z

Result of nixpkgs-review pr 267301 run on x86_64-linux 1

2 packages failed to build:

qgis
qgis-ltr

nialov · 2024-01-14T07:49:46Z

Getting a build error for PDAL which is a bit unexpected I guess?

error: builder for '/nix/store/34r5sjavrbr7pjhj3a176zk96pizk999-pdal-2.5.6.drv' failed with exit code 2;
       last 25 log lines:
       > [ 36%] Building CXX object CMakeFiles/pdal_base.dir/pdal/StageExtensions.cpp.o
       > [ 36%] Building CXX object CMakeFiles/pdal_base.dir/pdal/StageFactory.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/Streamable.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/SubcommandKernel.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/Writer.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/XMLSchema.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/DeflateCompression.cpp.o
       > [ 37%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/LazPerfVlrCompression.cpp.o
       > /build/source/pdal/XMLSchema.cpp: In member function 'bool pdal::XMLSchema::validate(xmlDocPtr, const std::string&)':
       > /build/source/pdal/XMLSchema.cpp:257:9: error: invalid conversion from 'void (*)(void*, xmlErrorPtr)' {aka 'void (*)(void*, _xmlError*)'} to 'xmlStructuredErrorFunc' {aka 'void (*)(void*, const _xmlError*)'} [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-fpermissive-fpermissive8;;]
       >   257 |         &SchemaParserStructuredErrorHandler, m_global_context);
       >       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       >       |         |
       >       |         void (*)(void*, xmlErrorPtr) {aka void (*)(void*, _xmlError*)}
       > In file included from /build/source/pdal/XMLSchema.hpp:50,
       >                  from /build/source/pdal/XMLSchema.cpp:34:
       > /nix/store/iqjsxkcdnvvz1bfpq960ygicc5clz9hv-libxml2-2.12.3-unstable-2023-12-14-dev/include/libxml2/libxml/xmlschemas.h:156:65: note:   initializing argument 2 of 'void xmlSchemaSetParserStructuredErrors(xmlSchemaParserCtxtPtr, xmlStructuredErrorFunc, void*)'
       >   156 |                                          xmlStructuredErrorFunc serror,
       >       |                                          ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
       > [ 38%] Building CXX object CMakeFiles/pdal_base.dir/pdal/compression/ZstdCompression.cpp.o
       > [ 38%] Building CXX object CMakeFiles/pdal_base.dir/pdal/pdal_config.cpp.o
       > make[2]: *** [CMakeFiles/pdal_base.dir/build.make:2386: CMakeFiles/pdal_base.dir/pdal/XMLSchema.cpp.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > make[1]: *** [CMakeFiles/Makefile2:739: CMakeFiles/pdal_base.dir/all] Error 2
       > make: *** [Makefile:166: all] Error 2
       For full logs, run 'nix log /nix/store/34r5sjavrbr7pjhj3a176zk96pizk999-pdal-2.5.6.drv'.
error: 1 dependencies of derivation '/nix/store/219shfbf0y2sljyfi97bs9r1ifa02f3p-grass-8.3.1.drv' failed to build
error: 2 dependencies of derivation '/nix/store/qsc6v3k5r3af0pjh3wq3br11n9l987hn-qgis-ltr-unwrapped-3.28.14.drv' failed to build
error: 2 dependencies of derivation '/nix/store/3v0hbpdff85d575vb8jhpnmd2bda2lim-qgis-unwrapped-3.34.2.drv' failed to build
error: 1 dependencies of derivation '/nix/store/f9zjmknpw2lgrcc9d9p553nfyww1lgvg-qgis-3.28.14.drv' failed to build
error: 1 dependencies of derivation '/nix/store/l20aw7b6zh7yik6wqhrrzmjfwcjbq2z6-qgis-3.34.2.drv' failed to build
error: 2 dependencies of derivation '/nix/store/iwzfrx7r1gl8gsi5k4z3blb7mnp99q0k-review-shell.drv' failed to build

imincik · 2024-01-15T09:12:06Z

@nialov , thank you very much for reviewing

Getting a build error for PDAL which is a bit unexpected I guess?

I think, the reason why pdal build was failing at the moment of your review was because of latest staging-next containing some breaking libxml change which broke PDAL .

staging-next branch was merged 3 days ago and our PDAL fix was merged yesterday.

imincik · 2024-01-15T09:38:17Z

Result of nixpkgs-review pr 267301 run on x86_64-linux 1

2 packages failed to build:

qgis
qgis-ltr

qgis fails during `sip-build (see: #281100) which a new issue.

nixos-discourse · 2024-01-16T09:22:04Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/week-in-geospatial-team/37035/3

autra

Looks good to me! thanks for this, it's going to be really useful!

pkgs/applications/gis/qgis/default.nix

pkgs/applications/gis/qgis/unwrapped-ltr.nix

autra · 2024-09-12T10:02:17Z

pkgs/applications/gis/qgis/unwrapped.nix

For my culture, why do we need placeholder "out here? $out directly doesn't work?

Not sure if I remember correctly, but I guess just using $out didn't work.

Why not $(out)?

autra · 2024-09-12T15:57:55Z

Note: I've tested on the rebased version, build is passing and the executable is working fine (I tested only simple stuff: GetCapabilities and GetMap on a basic project).

imincik · 2024-09-18T10:20:19Z

Note: I've tested on the rebased version, build is passing and the executable is working fine (I tested only simple stuff: GetCapabilities and GetMap on a basic project).

Great thanks for reviewing this PR. I rebased it on current master.

The only remaining todo is to disable server by default and add some user friendly way to override it with withServer = true . Currently, it is quite hard to do, because qgis-unwrapped being called in let binding . Any suggestion ?

autra · 2024-09-19T12:36:51Z

The only remaining todo is to disable server by default and add some user friendly way to override it with withServer = true . Currently, it is quite hard to do, because qgis-unwrapped being called in let binding . Any suggestion ?

Well I'd just propagate the argument:

  qgis-unwrapped = libsForQt5.callPackage ./unwrapped.nix { withServer = withServer;  };

Not entirely sure this works, as I'm still new to nixpkgs.

I guess #259445 won't be of much help, since we need the wrap for python packages right?

imincik · 2024-09-25T13:01:01Z

@autra , @sikmir , what about b0e306f to make unwrapped package overridable (majority of changes in this commit is renaming of qgis-unwrapped variable to unwrapped) ?

autra · 2024-09-27T12:43:54Z

I'd prefer a solution that expose these parameters directly to the user:

it's more standard for the user (=the person using pkgs.qgis in their nix files)
it's more discoverable for the user (the only place they have to look at is the parameters of default.nix, they don't have to 1/ find where other files are imported 2/ look in these other files)

Granted, it's a bit more boilerplate for us because we have to propagate every parameters, but I prefer that than to put the burden on users.

Btw, I think we should also document these options in meta.longDescription, so that they appear in search.nixos.org.

imincik · 2024-09-30T12:34:25Z

I'd prefer a solution that expose these parameters directly to the user:

it's more standard for the user (=the person using pkgs.qgis in their nix files)

it's more discoverable for the user (the only place they have to look at is the parameters of default.nix, they don't have to 1/ find where other files are imported 2/ look in these other files)

Granted, it's a bit more boilerplate for us because we have to propagate every parameters, but I prefer that than to put the burden on users.

I agree.

Btw, I think we should also document these options in meta.longDescription, so that they appear in search.nixos.org.

Yes.

autra · 2024-10-25T15:16:21Z

Code looks good! Tested and works like expected. Thanks!

imincik · 2024-10-28T08:17:27Z

Code looks good! Tested and works like expected. Thanks!

Thanks for review.

imincik marked this pull request as draft November 13, 2023 21:10

imincik self-assigned this Nov 13, 2023

imincik mentioned this pull request Nov 13, 2023

qgis: Enable mapserver #259303

Closed

12 tasks

imincik force-pushed the qgis-server branch from c78cd5c to aa6708d Compare November 13, 2023 21:39

github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 13, 2023

ofborg bot requested review from lsix, nh2, sikmir and willcohen November 13, 2023 23:28

imincik force-pushed the qgis-server branch 5 times, most recently from 2369f2a to 1ad1fda Compare November 15, 2023 04:24

imincik changed the title ~~qgis: build with server support~~ qgis: add server support Nov 15, 2023

imincik requested a review from bgamari November 15, 2023 04:27

ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Nov 15, 2023

imincik marked this pull request as ready for review November 15, 2023 04:54

imincik force-pushed the qgis-server branch from 1ad1fda to 91af823 Compare January 15, 2024 09:15

ofborg bot requested review from das-g, nialov and r-burns January 15, 2024 12:55

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024

autra approved these changes Sep 12, 2024

View reviewed changes

imincik force-pushed the qgis-server branch 2 times, most recently from 0df17ec to 9dc5029 Compare September 18, 2024 10:14

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 18, 2024

ofborg bot requested review from autra and l0b0 September 18, 2024 10:53

l0b0 removed their request for review September 18, 2024 21:30

imincik force-pushed the qgis-server branch from 9dc5029 to b0e306f Compare September 25, 2024 12:59

ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 25, 2024

imincik force-pushed the qgis-server branch from b0e306f to 2e06b5e Compare October 21, 2024 10:50

qgis: add server support

9067c29

imincik force-pushed the qgis-server branch from 2e06b5e to 9067c29 Compare October 24, 2024 07:35

autra approved these changes Oct 25, 2024

View reviewed changes

imincik merged commit 120be03 into NixOS:master Oct 28, 2024

Uh oh!

Conversation

imincik commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

imincik commented Nov 15, 2023

Uh oh!

nixos-discourse commented Dec 18, 2023

Uh oh!

nixos-discourse commented Jan 9, 2024

Uh oh!

nialov commented Jan 14, 2024

Uh oh!

nialov commented Jan 14, 2024

Uh oh!

imincik commented Jan 15, 2024

Uh oh!

imincik commented Jan 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Jan 16, 2024

Uh oh!

autra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

autra Sep 12, 2024

Choose a reason for hiding this comment

Uh oh!

imincik Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

sikmir Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

autra commented Sep 12, 2024

Uh oh!

imincik commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

autra commented Sep 19, 2024

Uh oh!

imincik commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

autra commented Sep 27, 2024

Uh oh!

imincik commented Sep 30, 2024

Uh oh!

autra commented Oct 25, 2024

Uh oh!

imincik commented Oct 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

imincik commented Nov 13, 2023 •

edited

Loading

imincik commented Jan 15, 2024 •

edited

Loading

imincik commented Sep 18, 2024 •

edited

Loading

imincik commented Sep 25, 2024 •

edited

Loading